Upload:: Honor OUTPUT_EXT #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a good start but we will also need to update all of the UploadMethodXXXX files under mbed-os/tools/cmake/upload_methods to use this new signature. |
ccli8
force-pushed
the
upload_honor_output_ext
branch
from
33a6fc1 to
da69a17
Compare
|
Apply the |
|
Looks good just one fix ^ |
Change signature from: function(gen_upload_target TARGET_NAME BIN_FILE HEX_FILE) To: function(gen_upload_target TARGET_NAME BINARY_FILE) If OUTPUT_EXT is undefined or defined to "bin", BINARY_FILE is .bin file, otherwise .hex file. The update applies to all UploadMethodXxx files.
ccli8
force-pushed
the
upload_honor_output_ext
branch
from
da69a17 to
54a6efb
Compare
multiplemonomials
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR changes upload method
gen_upload_targetsignature from:To:
If
OUTPUT_EXTis undefined or defined to "bin", BINARY_FILE is .bin file, otherwise .hex file.The update applies to all UploadMethodXxx files.
Replace #329
Pull request type